Skip to content

core: frontend: SettingsView: Prevent system log delete while downloading #3782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrickelectric wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: frontend: SettingsView: Prevent system log delete while downloading #3782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions core/frontend/src/views/SettingsView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@
class="mr-2"
outlined
small
:disabled="deletion_in_progress"
@click="download_service_log_files"
>
<v-icon left small>
Expand All @@ -251,7 +252,7 @@
v-tooltip="'Free up space by removing old logs'"
outlined
small
:disabled="disable_remove || deletion_in_progress"
:disabled="disable_remove || deletion_in_progress || downloading"
color="error"
@click="remove_service_log_files"
>
Expand Down Expand Up @@ -516,6 +517,7 @@ export default Vue.extend({
operation_description: '',
operation_error: undefined as undefined | string,
deletion_in_progress: false,
downloading: false,
deletion_log_abort_controller: null as null | AbortController,
current_deletion_path: '',
current_deletion_size: 0,
Expand Down Expand Up @@ -563,8 +565,13 @@ export default Vue.extend({
},

async download_service_log_files(): Promise<void> {
const folder = await filebrowser.fetchFolder('system_logs')
await filebrowser.downloadFolder(folder)
this.downloading = true
try {
const folder = await filebrowser.fetchFolder('system_logs')
await filebrowser.downloadFolder(folder)
} finally {
this.downloading = false
}
},

async download_mavlink_log_files(): Promise<void> {
Expand Down