Skip to content

Conversation

hudlow
Copy link
Contributor

@hudlow hudlow commented Oct 8, 2025

From the updated README.md:

The nested additional-examples directory has additional examples with changes represented in a sparse directory tree which can, in turn, have its own additional-examples directory. Running make ci will perform validations on the current directory, and recursively copy itself and the rest of the boilerplate into the tree of additional-examples directories to construct and then run validations for each override scenario.

@hudlow hudlow requested a review from jrinehart-buf October 8, 2025 22:15
@jrinehart-buf
Copy link
Contributor

  1. I've fixed CI.
  2. @hudlow and I discussed renaming "supplementary" to support better discoverability and he's working on the change.

Copy link
Contributor

@jrinehart-buf jrinehart-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Adding @timostamm as a reviewer for the .proto: let's make sure we're fixing the initial issue with predefined rules examples.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, but don't want to block merge. This is great.

@hudlow hudlow merged commit 17e041e into main Oct 20, 2025
9 checks passed
@hudlow hudlow deleted the hudlow/predefined-rules branch October 20, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants