Skip to content

Rework examples for predefined rules #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 20, 2025
+6,354 −861
Merged

Rework examples for predefined rules #134

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9c9dd0b
Rework examples for predefined rules
hudlow Oct 8, 2025
b04ff07
Clean up missed redundant test files
hudlow Oct 9, 2025
abdef73
Merge branch 'main' into hudlow/predefined-rules
jrinehart-buf Oct 10, 2025
b3ac8d3
Update README.md and fix Makefile
jrinehart-buf Oct 10, 2025
475838c
Update ci to use the existing BUF_TOKEN secret
jrinehart-buf Oct 10, 2025
541aaed
Update CLI version in CI
jrinehart-buf Oct 10, 2025
b03ab0e
Rename 'supplementary' directories to 'additional-examples' per feedback
hudlow Oct 14, 2025
cb4bcd1
Merge branch 'main' into hudlow/predefined-rules
jrinehart-buf Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
ci:
name: CI for all examples
runs-on: ubuntu-latest
env:
BUF_TOKEN: ${{ secrets.BUF_TOKEN }}
steps:
- name: Checkout Code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
Expand All @@ -32,7 +34,7 @@ jobs:
java-version: '11'
cache: 'gradle'
- name: Install Buf CLI
run: go install github.com/bufbuild/buf/cmd/buf@v1.50.0
run: go install github.com/bufbuild/buf/cmd/buf@v1.57.2
- name: Install golangci-lint
run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.5.0
- name: Install Protoc
Expand Down
13 changes: 4 additions & 9 deletions protovalidate/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ ci: clean \
install \
ci-compiling-buf \
ci-compiling-protoc \
ci-rules-predefined-finish \
ci-rules-predefined-start \
ci-rules-predefined \
ci-quickstart-go-start \
ci-quickstart-go-finish \
ci-quickstart-es-start \
Expand All @@ -49,13 +48,9 @@ ci: clean \
ci-bufstream-start \
ci-bufstream-finish

.PHONY: ci-rules-predefined-start
ci-rules-predefined-start:
cd rules-predefined/start&& $(MAKE) ci

.PHONY: ci-rules-predefined-finish
ci-rules-predefined-finish:
cd rules-predefined/finish&& $(MAKE) ci
.PHONY: ci-rules-predefined
ci-rules-predefined:
cd rules-predefined&& $(MAKE) ci

.PHONY: ci-compiling-buf
ci-compiling-buf:
Expand Down
6 changes: 6 additions & 0 deletions protovalidate/quickstart-es/start/buf.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Generated by buf. DO NOT EDIT.
version: v2
deps:
- name: buf.build/bufbuild/protovalidate
commit: 52f32327d4b045a79293a6ad4e7e1236
digest: b5:cbabc98d4b7b7b0447c9b15f68eeb8a7a44ef8516cb386ac5f66e7fd4062cd6723ed3f452ad8c384b851f79e33d26e7f8a94e2b807282b3def1cd966c7eace97
Loading
Loading