Fix on Windows #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's doesnt work on Windows when files have file encodings with '\n'. os.EOL returns '\n\r' so we have array sourceByLine as one string instead of multivalues. Then commentCodeInsideBlocks can't find this big string in truthyBlocks and nothing do.
|
I would suggest to use the regular expression /[\r\n]+/g to detect end of lines:
|
bbert
reviewed
Oct 9, 2018
| module.exports = function (source) { | ||
| try { | ||
| const sourceByLine = source.split(os.EOL) | ||
| const sourceByLine = source.split('\n') |
There was a problem hiding this comment.
I would suggest to use regular /[\r\n]+/g to detect end of lines on all systems
const sourceByLine = source.split(/[\r\n]+/g)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's doesnt work on Windows when files have file encodings with '\n'.
os.EOL returns '\n\r' so we have array sourceByLine as one string instead of multivalues.
Then commentCodeInsideBlocks can't find this big string in truthyBlocks and nothing do.