BareExampleApp: Upgrade RN to 0.80. Use RNEF. Fix stability issues #71
Conversation
|
wjaszczuk
force-pushed
the
50-e2e-stability
branch
2 times, most recently
from
8192d6a to
1e0750b
Compare
|
I added tap on Android because I noticed that API 33 uses an additional modal window on a fresh Chrome instance. That was the reason for the test failure on API 33. |
| run: yarn workspace react-native-legal-bare-example generate:legal | ||
| shell: bash | ||
|
|
||
| - name: "[WORKAROUND] run generateCodegenArtifactsFromSchema manually for example app" |
There was a problem hiding this comment.
Is this workaround done, because RNEF does not invoke codegen when building native part?
There was a problem hiding this comment.
I tested it with and without RNEF. I spent some time fighting this bug, and @artus9033 helped me with it. It started working with this script before the build. Without it, it breaks. The build. My plan was to commit it with a workaround and then try to fix this bug in a separate context.
| hermesCommand = new File(["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim()).getParentFile().getAbsolutePath() + "/sdks/hermesc/%OS-BIN%/hermesc" | ||
| codegenDir = new File(["node", "--print", "require.resolve('@react-native/codegen/package.json')"].execute(null, rootDir).text.trim()).getParentFile().getAbsoluteFile() | ||
| cliFile = new File(["node", "--print", "require.resolve('react-native/package.json')"].execute(null, rootDir).text.trim(), 'cli.js') | ||
| cliFile = file("../../node_modules/@rnef/cli/dist/src/bin.js") |
There was a problem hiding this comment.
Could we align to previous syntax that supports any nested location of cli script?
There was a problem hiding this comment.
I followed the RNEF docs, but I agree with you. It should be in the same format as the other files above.
| mavenCentral() | ||
| } | ||
| dependencies { | ||
| classpath("com.mikepenz.aboutlibraries.plugin:aboutlibraries-plugin:11.6.3") |
There was a problem hiding this comment.
I think this is line added by the generate command, let's remove it
…fications make things easier"
…iables like this in build.gradle in bare-example android app
wjaszczuk
force-pushed
the
50-e2e-stability
branch
from
e0c14bc to
13257ad
Compare
…for bare-example app
.github/workflows/test-e2e-ios.yaml
Outdated
| - name: Download and Unpack APK artifact | ||
| run: | | ||
| curl -L -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -o artifact.zip "https://api.github.com/repos/${{ github.repository }}/actions/artifacts/${{ needs.build-release.outputs.artifact-id }}/zip" | ||
| unzip artifact.zip -d downloaded-artifacts | ||
| tar zxf downloaded-artifacts/app.tar.gz -C downloaded-artifacts | ||
| ls -l downloaded-artifacts | ||
| APP_PATH=$(pwd)/$(find downloaded-artifacts -name "*.app" -print -quit) | ||
| echo "ARTIFACT_PATH_FOR_E2E=$APP_PATH" >> $GITHUB_ENV | ||
| shell: bash |
There was a problem hiding this comment.
instead of doing custom logic you can use remote-cache command from: callstackincubator/rock#263. i'm linking the PR because it's not documented yet.
There was a problem hiding this comment.
You can find the docs here now: https://www.rnef.dev/docs/cli#rnef-remote-cache-actions-and-options
There was a problem hiding this comment.
Great! I'll use it
| @@ -0,0 +1,4 @@ | |||
| // | |||
…download in GH actions for e2e
wjaszczuk
force-pushed
the
50-e2e-stability
branch
5 times, most recently
from
812fd9a to
645ea85
Compare
wjaszczuk
force-pushed
the
50-e2e-stability
branch
from
645ea85 to
d19a2c6
Compare
|
I need some time to fix it. I convert it to draft |
This PR:
--pure-lockfiledue to deprecation warningsThis PR fixes #50