BareExampleApp: Upgrade RN to 0.80. Use RNEF. Fix stability issues #71
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,5 +11,5 @@ runs: | |
| node-version: 20 | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --immutable | ||
| shell: bash | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,18 +29,60 @@ concurrency: | |
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-release: | ||
| runs-on: macos-15 | ||
| outputs: | ||
| artifact-id: ${{ steps.rnef-remote-build-ios.outputs.artifact-id }} | ||
| artifact-url: ${{ steps.rnef-remote-build-ios.outputs.artifact-url }} | ||
|
|
||
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Run generate:legal from bare-example | ||
| run: yarn workspace react-native-legal-bare-example generate:legal | ||
| shell: bash | ||
|
|
||
| - name: Build iOS | ||
| id: rnef-remote-build-ios | ||
| uses: callstackincubator/ios@v1 | ||
| with: | ||
| destination: 'simulator' | ||
| scheme: 'ReactNativeLegalBareExample' | ||
| configuration: 'Release' | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| working-directory: ./examples/bare-example | ||
| comment-bot: false | ||
|
|
||
| run-e2e-tests: | ||
| runs-on: macos-15 | ||
| needs: build-release | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| simulator: ['iPhone 16 Pro', 'iPhone SE (3rd generation)'] | ||
|
|
||
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Download and Unpack APK artifact | ||
| run: | | ||
| curl -L -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" -o artifact.zip "https://api.github.com/repos/${{ github.repository }}/actions/artifacts/${{ needs.build-release.outputs.artifact-id }}/zip" | ||
| unzip artifact.zip -d downloaded-artifacts | ||
| tar zxf downloaded-artifacts/app.tar.gz -C downloaded-artifacts | ||
| ls -l downloaded-artifacts | ||
| APP_PATH=$(pwd)/$(find downloaded-artifacts -name "*.app" -print -quit) | ||
| echo "ARTIFACT_PATH_FOR_E2E=$APP_PATH" >> $GITHUB_ENV | ||
| shell: bash | ||
|
||
|
|
||
| - name: Setup | ||
| uses: ./.github/actions/setup | ||
|
|
||
|
|
@@ -49,38 +91,13 @@ jobs: | |
| with: | ||
| target-platform: ios | ||
|
|
||
| - name: List simulators | ||
| run: xcrun simctl list | ||
|
|
||
| - name: Install on simulator | ||
| run: | | ||
| cd examples/bare-example | ||
| npx rnef run:ios --binary-path "$ARTIFACT_PATH_FOR_E2E" --device "${{ matrix.simulator }}" --local | ||
|
|
||
| - name: Run tests | ||
| run: yarn workspace react-native-legal-bare-example e2e:ios | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this workaround done, because RNEF does not invoke codegen when building native part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it with and without RNEF. I spent some time fighting this bug, and @artus9033 helped me with it. It started working with this script before the build. Without it, it breaks. The build. My plan was to commit it with a workaround and then try to fix this bug in a separate context.