Update HGCal testbeam relval workflow #48941

hqucms · 2025-09-16T17:24:04Z

PR description:

This PR updates the HGCal testbeam relval (workflow 77.0) to start from the DTH-P2 raw data.

This PR requires:

Fix to HGCAL unpacker: Move from FEDRawDataCollection to RawDataBuffer #48895
Update modulelocator file used for relval testing cms-data/Geometry-HGCalMapping#7
Update level0_calib_params used for relval testing cms-data/RecoLocalCalo-HGCalRecProducers#2

PR validation:

runTheMatrix.py -w standard --ibeos -l 77

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport foreseen.

cmsbuild · 2025-09-16T17:24:32Z

cms-bot internal usage

cmsbuild · 2025-09-16T17:25:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48941/46097

hqucms · 2025-09-16T17:39:31Z

test parameters:

pull_requests = Fix to HGCAL unpacker: Move from FEDRawDataCollection to RawDataBuffer #48895, Update modulelocator file used for relval testing cms-data/Geometry-HGCalMapping#7, Update level0_calib_params used for relval testing cms-data/RecoLocalCalo-HGCalRecProducers#2
workflow = 77.0

cmsbuild · 2025-09-16T17:39:52Z

A new Pull Request was created by @hqucms for master.

It involves the following packages:

RecoLocalCalo/Configuration (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @denizsun, @missirol, @rovere, @salimcerci, @sameasy, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

hqucms · 2025-09-16T17:40:19Z

please test

hqucms · 2025-09-16T17:42:23Z

assign hgcal-dpg

cmsbuild · 2025-09-16T17:42:45Z

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2025-09-16T20:39:44Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-063c81/48169/summary.html
COMMIT: c99cf57
CMSSW: CMSSW_16_0_X_2025-09-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48941/48169/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 13 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3978581
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3978540
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 181 edm output root files, 49 DQM output files
TriggerResults: no differences found

pfs · 2025-09-16T20:54:39Z

RecoLocalCalo/Configuration/python/hgcalTestBeamLocalReco_cff.py

+    localdir = 'local_daq/ramdisk/run20000000'
+    os.makedirs(localdir, exist_ok=True)
+    for f in files:
+        os.system(f'xrdcp --silent -f root://cms-xrd-global.cern.ch//{inputdir}/{f} {localdir}')


just a question: is it unavoidable to copy the files over?

AFAIK the DAQSource does not speak the xrootd protocol.

I think you can avoid making a copy of the files if the machine(s) where the jobs are run mount /eos/cms/store/group/dpg_hgcal/comm_hgcal/relval/.

fwyzard · 2025-09-17T06:55:30Z

test parameters:

pull_requests = Fix to HGCAL unpacker: Move from FEDRawDataCollection to RawDataBuffer #48895, Update modulelocator file used for relval testing cms-data/Geometry-HGCalMapping#7, Update level0_calib_params used for relval testing cms-data/RecoLocalCalo-HGCalRecProducers#2
enable = gpu
workflow = 77.0
workflow_gpu = 77.0

pfs · 2025-09-22T11:19:10Z

I tested locally and there's no problem with gpu enable. The error here seems to be is that the workflow is not defined in the list of RelVals AMD_MI300X, etc. Can someone guide me where should this be defined (or the twiki that explains it)?

fwyzard · 2025-09-22T11:27:33Z

Mhm, I though the entry workflow_gpu = 77.0 in the test commands would take care of that 🤔

fwyzard · 2025-09-22T11:29:12Z

Let's try this...

pfs · 2025-09-22T11:29:13Z

ok thanks, let me keep investigating. I'll trigger the tests again as I want to get the commands with a more recent IB that includes #48944

pfs · 2025-09-22T11:29:28Z

please test

fwyzard · 2025-09-22T11:30:46Z

test parameters:

pull_requests = Fix to HGCAL unpacker: Move from FEDRawDataCollection to RawDataBuffer #48895, Update modulelocator file used for relval testing cms-data/Geometry-HGCalMapping#7, Update level0_calib_params used for relval testing cms-data/RecoLocalCalo-HGCalRecProducers#2
enable = gpu
workflow = 77.0
workflow_gpu = 77.0
workflow_options_gpu = -w standard,gpu

fwyzard · 2025-09-22T11:31:13Z

please test

cmsbuild · 2025-09-22T19:40:12Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-063c81/48236/summary.html
COMMIT: c99cf57
CMSSW: CMSSW_16_0_X_2025-09-22-1100/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48941/48236/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 16 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3911484
DQMHistoTests: Total failures: 29
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3911435
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 219 log files, 189 edm output root files, 51 DQM output files
TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53486
DQMHistoTests: Total failures: 7198
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 46288
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53486
DQMHistoTests: Total failures: 8160
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 45326
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53486
DQMHistoTests: Total failures: 7623
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 45863
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53486
DQMHistoTests: Total failures: 9871
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 43615
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

pfs · 2025-09-22T19:47:26Z

ok looks like it ran fine!

pfs · 2025-09-22T19:48:05Z

+1

jfernan2 · 2025-09-23T16:36:23Z

+1

cmsbuild · 2025-09-23T16:36:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #48895, cms-data/Geometry-HGCalMapping#7, cms-data/RecoLocalCalo-HGCalRecProducers#2

mandrenguyen · 2025-09-25T11:04:44Z

+1

Update HGCal testbeam relval (wf 77.0).

c99cf57

cmsbuild added this to the CMSSW_16_0_X milestone Sep 16, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2025

hqucms marked this pull request as ready for review September 16, 2025 17:39

cmsbuild added the requires-external label Sep 16, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 16, 2025

cmsbuild added the hgcal-dpg-pending label Sep 16, 2025

hqucms mentioned this pull request Sep 16, 2025

Update modulelocator file used for relval testing cms-data/Geometry-HGCalMapping#7

Merged

cmsbuild added tests-approved and removed tests-started labels Sep 16, 2025

pfs reviewed Sep 16, 2025

View reviewed changes

pfs mentioned this pull request Sep 17, 2025

[HGCAL] Add ECON-T indexer for reading out TPG data #48648

Merged

cmsbuild removed requires-external tests-approved labels Sep 17, 2025

cmsbuild added the tests-rejected label Sep 17, 2025

cmsbuild added tests-started and removed tests-rejected labels Sep 22, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 22, 2025

cmsbuild added hgcal-dpg-approved and removed hgcal-dpg-pending labels Sep 22, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Sep 23, 2025

cmsbuild mentioned this pull request Sep 23, 2025

Fix to HGCAL unpacker: Move from FEDRawDataCollection to RawDataBuffer #48895

Merged

cmsbuild mentioned this pull request Sep 23, 2025

Update level0_calib_params used for relval testing cms-data/RecoLocalCalo-HGCalRecProducers#2

Merged

cmsbuild added orp-approved and removed orp-pending labels Sep 25, 2025

cmsbuild merged commit b5c6af4 into cms-sw:master Sep 25, 2025
23 checks passed

cmsbuild mentioned this pull request Sep 25, 2025

Add test for reading files with different ProductRegistries #48996

Merged

Update HGCal testbeam relval workflow #48941

Update HGCal testbeam relval workflow #48941

Uh oh!

Conversation

hqucms commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 16, 2025

Uh oh!

hqucms commented Sep 16, 2025

Uh oh!

cmsbuild commented Sep 16, 2025

Uh oh!

hqucms commented Sep 16, 2025

Uh oh!

hqucms commented Sep 16, 2025

Uh oh!

cmsbuild commented Sep 16, 2025

Uh oh!

cmsbuild commented Sep 16, 2025

Comparison Summary

Uh oh!

pfs Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pfs commented Sep 22, 2025

Uh oh!

fwyzard commented Sep 22, 2025

Uh oh!

fwyzard commented Sep 22, 2025

Uh oh!

pfs commented Sep 22, 2025

Uh oh!

pfs commented Sep 22, 2025

Uh oh!

fwyzard commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025

Comparison Summary

AMD_MI300X Comparison Summary

NVIDIA_H100 Comparison Summary

NVIDIA_L40S Comparison Summary

NVIDIA_T4 Comparison Summary

Uh oh!

pfs commented Sep 22, 2025

Uh oh!

pfs commented Sep 22, 2025

Uh oh!

jfernan2 commented Sep 23, 2025

Uh oh!

cmsbuild commented Sep 23, 2025

Uh oh!

mandrenguyen commented Sep 25, 2025

Uh oh!

Uh oh!

Uh oh!

hqucms commented Sep 16, 2025 •

edited

Loading

cmsbuild commented Sep 16, 2025 •

edited

Loading

fwyzard commented Sep 17, 2025 •

edited

Loading

fwyzard commented Sep 22, 2025 •

edited

Loading