Skip to content

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 22, 2025

backport of #48957

PR description:

From the original PR description:

Title says it all: the DAQ group is preparing the global system for running with the secondary TCDS system, where FED 1050 would be present as TCDS FED instead of 1024, see more details at CMSHLT-3643.
Considering HLT, they went through the modules consuming FED 1024 and they found that the module HLTL1NumberFilter does not support multiple FED input values, thus it can work with both FED IDs in global HLT.
The goal of this PR is to support multiple TCDS FEDs in input.

PR validation:

TSG integration tests: addOnTests.py works.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #48957 to the 2025 PbPb data-taking release, for online tests.

Cc: @smorovic

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2025

A new Pull Request was created by @mmusich for CMSSW_15_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • HLTrigger/special (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c05b9/48232/summary.html
COMMIT: 10effed
CMSSW: CMSSW_15_1_X_2025-09-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48965/48232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113751
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113728
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a388a29 into cms-sw:CMSSW_15_1_X Sep 25, 2025
8 checks passed
@mmusich mmusich deleted the dev_support_secondaryTCDS_15_1_X branch September 25, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants