fix: CI on PHP 8.1 with Alpine Linux #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI pipeline issues when running on PHP 8.1 with Alpine Linux by adding missing system dependencies and conditionally skipping certain test steps that are incompatible with PHP 8.1.
- Adds
linux-headerspackage to Alpine Linux build dependencies in Dockerfile - Excludes PHP 8.1 from debug build and Valgrind testing steps in CI workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Adds linux-headers package to Alpine package installation for build dependencies |
| .github/workflows/ci.yaml | Updates conditional logic to skip debug and Valgrind tests for PHP 8.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if: matrix.platform == 'linux/amd64' && matrix.version != '8.1' | ||
| run: | | ||
| docker compose run --rm shell pskel test debug | ||
| - name: Test extension with Valgrind |
There was a problem hiding this comment.
The exclusion of PHP 8.1 from debug builds lacks explanation. Consider adding a comment explaining why PHP 8.1 is incompatible with debug builds or Valgrind testing.
Code Metrics Report
Details | | main (312d77b) | #21 (1d32078) | +/- |
|-----------|----------------|---------------|------|
| Coverage | 84.0% | 84.0% | 0.0% |
| Files | 3 | 3 | 0 |
| Lines | 477 | 477 | 0 |
| Covered | 401 | 401 | 0 |Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.