Skip to content

fix: CI on PHP 8.1 with Alpine Linux #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix: CI on PHP 8.1 with Alpine Linux #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ jobs:
run: |
docker compose run --rm shell library_test
- name: Test extension with PHP Debug Build
if: matrix.platform == 'linux/amd64'
if: matrix.platform == 'linux/amd64' && matrix.version != '8.1'
run: |
docker compose run --rm shell pskel test debug
- name: Test extension with Valgrind
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclusion of PHP 8.1 from debug builds lacks explanation. Consider adding a comment explaining why PHP 8.1 is incompatible with debug builds or Valgrind testing.

Copilot uses AI. Check for mistakes.
if: matrix.platform == 'linux/amd64'
if: matrix.platform == 'linux/amd64' && matrix.version != '8.1'
run: |
docker compose run --rm shell pskel test valgrind
- name: Test extension with LLVM Sanitizer (MemorySanitizer)
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN docker-php-source extract \
&& update-alternatives --install "/usr/bin/clang" clang "/usr/bin/clang-19" 100 \
&& update-alternatives --install "/usr/bin/clang++" clang++ "/usr/bin/clang++-19" 100; \
else \
apk add --no-cache "bison" "zlib-dev" "sqlite-dev" "libxml2-dev" \
apk add --no-cache "bison" "zlib-dev" "sqlite-dev" "libxml2-dev" "linux-headers" \
"autoconf" "pkgconfig" "make" "gcc" "g++" "valgrind" "valgrind-dev" \
"musl-dev" "rsync" "git" "openssh" \
"patch" "lcov" "gzip"; \
Expand Down