Adding more cw20 testnet tokens on terra classic testnet as well some photos on terra to link them #6642
Conversation
| "images": [ | ||
| { | ||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/terra/images/paxg.png" | ||
| } |
There was a problem hiding this comment.
For all these images, they already exist elsewhere in the repo, so these would be duplicates. Please remove the images being uploaded here and use the URIs for the already uploaded images instead (using image_sync, and it will also require traces)
There was a problem hiding this comment.
the point is to have them on their terra folder not use someone elses repo to fetch the image
There was a problem hiding this comment.
This registry prioritizes avoiding duplicate images over the comfort of having all of a chain's tokens' images within that chain's /images/ directory. It fragments branding data (makes it harder to update token logos) and needlessly bloats the size of the repo.
There was a problem hiding this comment.
This registry prioritizes avoiding duplicate images over the comfort of having all of a chain's tokens' images within that chain's /images/ directory. It fragments branding data (makes it harder to update token logos) and needlessly bloats the size of the repo.
i know dapps fetching stuff from here even leap - if that wont cause issue on their side to re upload the image then ok no prob
There was a problem hiding this comment.
This registry prioritizes avoiding duplicate images over the comfort of having all of a chain's tokens' images within that chain's /images/ directory. It fragments branding data (makes it harder to update token logos) and needlessly bloats the size of the repo.
done
|
The URIs are all incorrect (ethereum and bitcoin are both under /_non-cosmos/ directory). And please define 'traces' for these assets so we know how they relate to their origin (How is USDT in Terra Classic related to USDT on Ethereum? did Tether issue USDT here? is it bridged? is it a scam copycat?), which will allow the images to be kept in sync. |
its testnet photos not for main net |
Regardless, we still want to avoid duplicate images |
done them all /_non-cosmos/ |
|
The validation requirements were updated but this PR is sill running against branch diverged from before that, so there is at least one broken reference. Please pull master into this branch. |
3 participants
No description provided.