-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding more cw20 testnet tokens on terra classic testnet as well some photos on terra to link them #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
niodamian
wants to merge
9
commits into
cosmos:master
Choose a base branch
from
niodamian:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−1
Draft
Adding more cw20 testnet tokens on terra classic testnet as well some photos on terra to link them #6642
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1688f7a
Add files via upload
niodamian d6b318d
Update assetlist.json
niodamian b975fd4
Delete terra/images/btc.png
niodamian b0ed03d
Delete terra/images/eth.png
niodamian 3869bf6
Delete terra/images/paxg.png
niodamian 29f45a2
Delete terra/images/usdc.png
niodamian 3be7b99
Delete terra/images/usdt.png
niodamian cac95b9
Update assetlist.json
niodamian 5c9b566
Update assetlist.json
niodamian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all these images, they already exist elsewhere in the repo, so these would be duplicates. Please remove the images being uploaded here and use the URIs for the already uploaded images instead (using image_sync, and it will also require
traces)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point is to have them on their terra folder not use someone elses repo to fetch the image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This registry prioritizes avoiding duplicate images over the comfort of having all of a chain's tokens' images within that chain's /images/ directory. It fragments branding data (makes it harder to update token logos) and needlessly bloats the size of the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know dapps fetching stuff from here even leap - if that wont cause issue on their side to re upload the image then ok no prob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done