Added default case for unsupported methods in login handler#1226
Open
gemy26 wants to merge 1 commit intocybertec-postgresql:masterfrom
Open
Added default case for unsupported methods in login handler#1226gemy26 wants to merge 1 commit intocybertec-postgresql:masterfrom
gemy26 wants to merge 1 commit intocybertec-postgresql:masterfrom
Conversation
Mazen050
reviewed
Feb 23, 2026
| fmt.Fprintf(w, "only POST methods is allowed.") | ||
| default: | ||
| w.Header().Set("Allow", "POST") | ||
| http.Error(w, "method not allowed", http.StatusMethodNotAllowed) |
Contributor
There was a problem hiding this comment.
You should probably match the error message with the old one or change the expected message in the test.
I think matching the error messages is best here. This will also fix the CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added default case for unsupported methods.