Skip to content

[-] return HTTP 405 for non-POST methods in login handler #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pashagolub merged 2 commits into from
Feb 24, 2026
Merged

[-] return HTTP 405 for non-POST methods in login handler #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89688b5
Added default case for unsupported methods in login handler
gemy26 Feb 22, 2026
f920a20
fix tests
pashagolub Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/webserver/jwt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package webserver

import (
"errors"
"fmt"
"net/http"
"time"

Expand Down Expand Up @@ -48,8 +47,9 @@ func (s *WebUIServer) handleLogin(w http.ResponseWriter, r *http.Request) {
}
_, err = w.Write([]byte(token))

case "GET":
fmt.Fprintf(w, "only POST methods is allowed.")
default:
w.Header().Set("Allow", "POST")
http.Error(w, "only POST method is allowed", http.StatusMethodNotAllowed)
return
}
}
Expand Down
4 changes: 1 addition & 3 deletions internal/webserver/jwt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ func TestHandleLogin_GET(t *testing.T) {
w := httptest.NewRecorder()
ts.handleLogin(w, r)
resp := w.Result()
assert.Equal(t, http.StatusOK, resp.StatusCode)
body, _ := io.ReadAll(resp.Body)
assert.Equal(t, "only POST methods is allowed.", string(body))
assert.Equal(t, http.StatusMethodNotAllowed, resp.StatusCode)
}

func TestGenerateAndValidateJWT(t *testing.T) {
Expand Down
Loading