-
Couldn't load subscription status.
- Fork 188
feat: add support for service account impersonation #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
package.json
Outdated
| "@bazel/rollup": "^3.0.0", | ||
| "@bazel/typescript": "^3.0.0", | ||
| "@google-cloud/bigquery": "^5.6.0", | ||
| "@google-cloud/bigquery": "7.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it shouldn't be pinned to a specific version similar to other dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kolina for the review. Using ^7.1.1 results in the following error when doing bazel run @nodejs//:yarn add @google-cloud/bigquery@^7.1.1
error @google-cloud/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.16.0"However, we can use ~ to allow patch updates only (minor and major fixed). This installs without any issues. I have made this change in the lates commit.
Happy to change based on feedback. Trying a lower major version is another option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ceridan, can you please take a look here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we need to put it on hold for a while. We cannot easily upgrade to @google-cloud/[email protected] because it is not available on our npm mirror at the moment.
Additionally, there is a an ongoing work to update the whole toolchain for Dataform which will make it possible to upgrade NodeJS version and other dependencies to up to date versions.
|
Any further updates on when this will be merged? |
|
Unfortunately, we cannot merge this right now. It is required some additional work on build toolchain upgrade, which allows us to upgrade all the dependencies. This work will most likely be done in Q4'2025. |
Fixes: #2000
Solution:
Update @google-cloud/bigquery to a newer version which supports service account impersonation. The version number (~7.1.1) was set from finding the maximum version of @google-cloud/bigquery such that current minimum Node JS version (16.6.0) does not need to be changed.
Tests
The incoming JSON object does not contain a client_email fieldbazel test //core/...&./scripts/lintpasses