Skip to content

feat: add support for service account impersonation #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+135 −113
Open

feat: add support for service account impersonation #2001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547def0
feat: add support for service account impersonation
ashish10alex Aug 6, 2025
1cdc122
chore: using flexible patch version
ashish10alex Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@bazel/labs": "^0.42.3",
"@bazel/rollup": "^3.0.0",
"@bazel/typescript": "^3.0.0",
"@google-cloud/bigquery": "^5.6.0",
"@google-cloud/bigquery": "7.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it shouldn't be pinned to a specific version similar to other dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kolina for the review. Using ^7.1.1 results in the following error when doing bazel run @nodejs//:yarn add @google-cloud/bigquery@^7.1.1

error @google-cloud/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.16.0"

However, we can use ~ to allow patch updates only (minor and major fixed). This installs without any issues. I have made this change in the lates commit.

Happy to change based on feedback. Trying a lower major version is another option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ceridan, can you please take a look here?

"@google-cloud/storage": "^5.8.2",
"@rollup/plugin-node-resolve": "^7.1.3",
"@types/chai": "^4.1.7",
Expand Down
Loading