fix: update year limit check in for proper marshaling #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-datazip
added
the
hacktoberfest
| parsed = parsed.AddDate(0-parsed.Year(), 0, 0) | ||
| // even after data being parsed if year doesn't lie in range [1,9999] it failed to get marshaled | ||
| if parsed.Year() <= 0 { | ||
| parsed = parsed.AddDate(1-parsed.Year(), 0, 0) |
There was a problem hiding this comment.
@Itz-Agasta
hey can you provide the example using which you tested? I mean if possible the mongodb script if possible.
|
closing this. The PR for this has been raised by @vaibhav-datazip . |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where timestamps returned by MongoDB with year 0 caused json.Marshal to fail with the error:
The
ReformatDatefunction inutils/typeutils/reformat.gopreviously only adjusted negative years and years > 9999. Year == 0 slipped through unmodified and triggered the runtime error.Fixes #421
Type of change
How Has This Been Tested?
Ran:
go build ./...-> success