Skip to content

fix: update year limit check in for proper marshaling #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: update year limit check in for proper marshaling #559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e9143
fix: update year limit check in ReformatDate function for proper mars…
Itz-Agasta Oct 2, 2025
d019adb
Merge branch 'staging' into bug_fix
ImDoubD-datazip Oct 14, 2025
e711509
Merge branch 'staging' into bug_fix
ImDoubD-datazip Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions utils/typeutils/reformat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ func ReformatDate(v interface{}) (time.Time, error) {
}

// manage year limit
// even after data being parsed if year doesn't lie in range [0,9999] it failed to get marshaled
if parsed.Year() < 0 {
parsed = parsed.AddDate(0-parsed.Year(), 0, 0)
// even after data being parsed if year doesn't lie in range [1,9999] it failed to get marshaled
if parsed.Year() <= 0 {
parsed = parsed.AddDate(1-parsed.Year(), 0, 0)
Copy link
Collaborator

@ImDoubD-datazip ImDoubD-datazip Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itz-Agasta
hey can you provide the example using which you tested? I mean if possible the mongodb script if possible.

} else if parsed.Year() > 9999 {
parsed = parsed.AddDate(-(parsed.Year() - 9999), 0, 0)
}
Expand Down