-
Couldn't load subscription status.
- Fork 132
fix: add context while querying (sql/sqlx) (#319) #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is still a function in instead pass a ctx to the function and use that here. Also you can run the sync for the drivers which you have modified, as test if all the functionalities are working fine. |
|
LGTM |
|
Hi @ashh1215 , can you please resolve these conflicts in your PR |
Signed-off-by: ashh1215 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ashh1215
I saw that you did a force push recently. Looks like the merge conflicts were resolved, but not fully or correctly, few files still have issues after the merge.
Just a quick reminder from our contributing rules:
- Please make sure all merge conflicts are properly resolved before pushing.
- Try to avoid force pushes unless it’s really needed, since it can make the review history harder to follow.
Before pushing any changes, please do a quick round of local testing to confirm everything builds and works as expected.
Once that’s done, let me know and I’ll do another round of testing on my side. Thanks for your effort! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please go through you code and remove the code which is not required in your branch, i can still see old code which is not present in current staging , reflecting that merge conflicts were not resolved correctly.
one way to help you out will be, you can check the context related changes and keep them and remove other changes.
Merge latest changes from upstream staging branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added context parameter to all database query methods in driver files.
Fixes #319
Type of change
How Has This Been Tested?
go buildpasses for all modified driversgo vetpasses with no errorsDocumentation