Fix code scanning alert no. 3: Arbitrary file write during tarfile extraction #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/deepmodeling/dpdispatcher/security/code-scanning/3
To fix the problem, we need to ensure that the file paths within the tar archive are validated before extraction. Specifically, we should check that the paths do not contain any directory traversal elements (
..) and are not absolute paths. This can be done by iterating over the members of the tar file and performing these checks before extraction.Steps to fix:
...Suggested fixes powered by Copilot Autofix. Review carefully before merging.