Skip to content

Fix code scanning alert no. 3: Arbitrary file write during tarfile extraction #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix code scanning alert no. 3: Arbitrary file write during tarfile extraction #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dpdispatcher/contexts/hdfs_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@
tgz_file_list = glob(os.path.join(self.local_root, "tmp/*_download.tar.gz"))
for tgz in tgz_file_list:
with tarfile.open(tgz, "r:gz") as tar:
for member in tar.getmembers():
member_path = os.path.join(gz_dir, member.name)
if os.path.isabs(member.name) or ".." in member.name:
raise ValueError(f"Illegal tar archive entry: {member.name}")

Check warning on line 150 in dpdispatcher/contexts/hdfs_context.py

View check run for this annotation

Codecov / codecov/patch

dpdispatcher/contexts/hdfs_context.py#L147-L150 

Added lines #L147 - L150 were not covered by tests
tar.extractall(path=gz_dir)

for task in submission.belonging_tasks:
Expand Down
Loading