Update log level when configuring websocket #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssaengs
reviewed
Nov 7, 2025
| // logDiagnostic writes a diagnostic message to the specified writer. | ||
| // This is used for logging infrastructure issues (not application logs). | ||
| // Messages are written as JSON to maintain consistency with application logs. | ||
| // The log level is determined by the writer: stderr produces error level, stdout produces info level. |
Collaborator
There was a problem hiding this comment.
This should be debug by default since they will potentially be very noisy.
ssaengs
reviewed
Nov 7, 2025
| // determine log level based on the writer | ||
| level := "info" | ||
| if w == os.Stderr { | ||
| level = "error" |
Collaborator
There was a problem hiding this comment.
I think this can be dropped.
When using stdio transport, log messages are routed to the stdout stream for JSON rpc calls between the client and the server. In order to not interfere with with client and server communication, the mcp protocol states that debug error messages should be routed to the stderr stream. So using stderr as transport does not equate to an error level log. We shouldn't mix those two.
Suggested change
| level = "error" | |
| level = "error" |
https://modelcontextprotocol.io/specification/2025-06-18/basic/transports#stdio
The server MAY write UTF-8 strings to its standard error (stderr) for logging purposes. Clients MAY capture, forward, or ignore this logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.