Skip to content

Update log level when configuring websocket #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update log level when configuring websocket #189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e62167
Update log level when configuring websocket
thearyanahmed Nov 7, 2025
6bdbd7d
Fix comment
thearyanahmed Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/wslogging/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,13 +449,20 @@ func (h *Handler) connect(wsURL, token string) (*websocket.Conn, error) {
// logDiagnostic writes a diagnostic message to the specified writer.
// This is used for logging infrastructure issues (not application logs).
// Messages are written as JSON to maintain consistency with application logs.
// The log level is determined by the writer: stderr produces error level, stdout produces info level.
Copy link
Collaborator

@ssaengs ssaengs Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be debug by default since they will potentially be very noisy.

func logDiagnostic(w io.Writer, format string, args ...any) {
message := fmt.Sprintf(format, args...)
// trim trailing newline if present (we'll add it back after JSON)
message = strings.TrimSuffix(message, "\n")

// determine log level based on the writer
level := "info"
if w == os.Stderr {
level = "error"
Copy link
Collaborator

@ssaengs ssaengs Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be dropped.

When using stdio transport, log messages are routed to the stdout stream for JSON rpc calls between the client and the server. In order to not interfere with with client and server communication, the mcp protocol states that debug error messages should be routed to the stderr stream. So using stderr as transport does not equate to an error level log. We shouldn't mix those two.

Suggested change
level = "error"
level = "error"

https://modelcontextprotocol.io/specification/2025-06-18/basic/transports#stdio

The server MAY write UTF-8 strings to its standard error (stderr) for logging purposes. Clients MAY capture, forward, or ignore this logging.

}

entry := map[string]any{
"level": "ERROR",
"level": level,
"msg": message,
"source": "wslogging",
"time": time.Now().UTC().Format(time.RFC3339Nano),
Expand Down