HTTPClient preserves headers over redirects (#3173) #3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
requested changes
Oct 2, 2025
earlephilhower
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Thanks for the explanation. I missed the fact this was in a do..while. HTTPClient is one of the classes ported from the ESP8266 and has had a lot of authors and some interesting logic.
Anyway, LGTM now that I've got your explanation and a better look at the code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP headers are preserved over redirects.
Additional re-directed requests will include the same headers like the original request.
Fixes issue #3173