Skip to content

HTTPClient preserves headers over redirects (#3173) #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

HTTPClient preserves headers over redirects (#3173) #3175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88ef15c
HTTPClient preserves headers over redirects (#3173)
skaringa Oct 2, 2025
fc69dc6
Merge branch 'master' into fix_issue_3173
earlephilhower Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libraries/HTTPClient/src/HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,14 +578,23 @@ int HTTPClient::sendRequest(const char * type, const uint8_t * payload, size_t s
int code;
bool redirect = false;
uint16_t redirectCount = 0;
String headers;
do {
// wipe out any existing headers from previous request
// wipe out any existing response headers from previous request
for (size_t i = 0; i < _headerKeysCount; i++) {
if (_currentHeaders[i].value.length() > 0) {
_currentHeaders[i].value = "";
}
}

// keep request headers for redirects
// fixes #3173
if (redirect) {
_headers = headers;
} else {
headers = _headers;
}

DEBUG_HTTPCLIENT("[HTTP-Client][sendRequest] type: '%s' redirCount: %d\n", type, redirectCount);

// connect to server
Expand Down