Skip to content

Conversation

@willc001
Copy link
Contributor

@willc001 willc001 commented Oct 11, 2025

… brick is assigned

Refs DBMAINTAIN-1384

依赖检查

组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。

请勾选以下两组选项其中之一:

  • 本次 MR 没有使用上游组件(例如框架、后台组件等)的较新版本提供的特性。

或者:

  • 本次 MR 使用了上游组件(例如框架、后台组件等)的较新版本提供的特性。
  • 在对应的文件中更新了该上游组件的依赖版本(或确认了当前声明的依赖版本已包含本次 MR 使用的新特性)。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言,可以通过本次改动对下游使用者的影响来识别变更类型:

  • 下游使用者不做任何改动,仍可以正常工作时,那么它属于普通变更。
  • 反之,下游使用者不做改动就无法正常工作时,那么它属于破坏性变更。

例如,构件修改了一个属性名,小产品 Storyboard 中需要使用新属性名才能工作,那么它就是破坏性变更。
又例如,构件还没有任何下游使用者,那么它的任何变更都是普通变更。

破坏性变更:

  • ⚠️ 本次 MR 包含破坏性变更的提交,请继续确认以下所有选项:
  • 没有更好的兼容方案,必须做破坏性变更。
  • 使用了 feat 作为提交类型。
  • 标注了 BREAKING CHANGE: 你的变更说明
  • 同时更新了本仓库中所有下游使用者的调用。
  • 同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
  • 同时为其它仓库的 Migrating 做好了准备,例如文档或批量改动的方法。
  • 手动验证过破坏性变更在 Migrate 后可以正常工作。
  • 破坏性变更所在的提交没有意外携带其它子包的改动。

新特性:

  • 本次 MR 包含新特性的提交,且该提交不带有破坏性变更,并使用了 feat 作为提交类型。
  • 给新特性添加了单元测试。
  • 手动验证过新特性可以正常工作。

问题修复:

  • 本次 MR 包含问题修复的提交,且该提交不带有新特性或破坏性变更,并使用了 fix 作为提交类型。
  • 给问题修复添加了单元测试。
  • 手动验证过问题修复得到解决。

杂项工作:

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:

  • 本次 MR 包含杂项工作的提交,且该提交不带有问题修复、新特性或破坏性变更,并使用了 chore, docs, test 等作为提交类型。

@coderabbitai
Copy link

coderabbitai bot commented Oct 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch williamcai/brick-kit/BrickAsComponent/dispatch_mount_event_after_element_of_template_brick_is_assigned

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

weareoutman
weareoutman previously approved these changes Oct 11, 2025
@weareoutman weareoutman enabled auto-merge October 11, 2025 11:38
@willc001 willc001 force-pushed the williamcai/brick-kit/BrickAsComponent/dispatch_mount_event_after_element_of_template_brick_is_assigned branch from 2f1db8b to 8822833 Compare October 11, 2025 13:31
@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (a8efbe1) to head (8822833).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4807   +/-   ##
=======================================
  Coverage   93.09%   93.10%           
=======================================
  Files         317      317           
  Lines       10565    10566    +1     
  Branches     2019     2019           
=======================================
+ Hits         9836     9837    +1     
  Misses        448      448           
  Partials      281      281           
Files with missing lines Coverage Δ
packages/brick-kit/src/BrickAsComponent.tsx 84.71% <100.00%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Oct 11, 2025

next-core    Run #11740

Run Properties:  status check passed Passed #11740  •  git commit 6bdb164923 ℹ️: Merge 88228338934f340d2f29abc6a9cb03218704c2f7 into a8efbe1c6306e23b0a4056ec5215...
Project next-core
Branch Review refs/pull/4807/merge
Run status status check passed Passed #11740
Run duration 00m 27s
Commit git commit 6bdb164923 ℹ️: Merge 88228338934f340d2f29abc6a9cb03218704c2f7 into a8efbe1c6306e23b0a4056ec5215...
Committer William Cai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 6
View all changes introduced in this branch ↗︎

@weareoutman weareoutman merged commit 1af2920 into master Oct 12, 2025
8 checks passed
@weareoutman weareoutman deleted the williamcai/brick-kit/BrickAsComponent/dispatch_mount_event_after_element_of_template_brick_is_assigned branch October 12, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants