Skip to content

fix(BrickAsComponent): dispatch mount event after element of template… #4807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

fix(BrickAsComponent): dispatch mount event after element of template… #4807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/brick-kit/src/BrickAsComponent.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,7 @@ describe("BrickAsComponent", () => {
const wrapper = mount(<BrickAsComponent useBrick={useBrick} />);

await (global as any).flushPromises();
jest.runAllTimers();
onMountHandlers.map((handler) => {
expect(spiedListenerFactory).toBeCalledWith(
handler,
Expand Down
13 changes: 8 additions & 5 deletions packages/brick-kit/src/BrickAsComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,14 @@ export function SingleBrickAsComponentFactory(React: typeof _React) {

const onMount = useBrick.lifeCycle?.onMount;
if (onMount) {
dispatchLifeCycleEvent(
new CustomEvent("mount"),
transformEvents(data, { onMount }).onMount,
brick
);
// wait for element of template brick to be assigned
queueMicrotask(() => {
dispatchLifeCycleEvent(
new CustomEvent("mount"),
transformEvents(data, { onMount }).onMount,
brick
);
});
}

const onScrollIntoView = useBrick.lifeCycle?.onScrollIntoView;
Expand Down
Loading