-
Notifications
You must be signed in to change notification settings - Fork 12
replace platform test with platform integration test #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace platform test with platform integration test #233
Conversation
resolves: eclipse-score#164 Signed-off-by: Patil Deepa (ETAS-ECM/XPC-Fe2) <[email protected]>
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to start with big letter, Platform Integration Tests, all other start with big letters to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please use same style as others, Platform Integration Test
| This also covers the work product Verification Specification. | ||
|
|
||
| .. workproduct:: Platform test | ||
| .. workproduct:: platform integration test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow all other styles, Platform integration tests, see all changes
| Element out of Context (**SEooC**) (green box, top, 1st column). The objectives of the platform are | ||
| expressed as concrete **Stakeholder Requirements** (blue box, top, 2nd column), which can be tested | ||
| by provided **Platform Tests** (blue box, top, 5nd column) for reference hardware platforms. The | ||
| by provided **Platform Integration Tests** (blue box, top, 5th column) for reference hardware platforms. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use that form all over the changed documents and images
|
@pahmann , is there a corresponding ticket to update PMP, if this PR is merged? |
eclipse-score/score#1972 |
masc2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://eclipse-score.github.io/process_description/pr-233/general_concepts/score_building_blocks_concept.html
Please check the image, Still Platform Test mentioned here
|
|
||
| .. workflow:: Create/Maintain Platform Test | ||
| .. workflow:: Create/Maintain Platform Integration Test | ||
| :id: wf__verification_platform_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have, change also id to wf__verification_platform_int_test, compare wf__verification_comp_int_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but you need also to change it in other places, where it is used, see error for documentation building, https://github.com/eclipse-score/process_description/actions/runs/19136353372/job/54689311376?pr=233
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done now at all other places. Also updated the name of work package to: wp__verification_platform_int_test which was previously wp__verification_platform_test! Build is through.
dc533d9 to
2fbbc1c
Compare
masc2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine now for me, thank you for your contribution
resolves: #164