feat: migrate electronDownload to use electron/get instead of app-builder
#8827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 71782c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
force-pushed
the
feat/electron-get
branch
from
9216ca4 to
c3efd23
Compare
…ectron/get Implements: #8785 Refactors the code surrounding download/unzip/copy electron before packing begins, so this might also resolve: #6106 #8687 #8522
mmaietta
force-pushed
the
feat/electron-get
branch
from
7f21f99 to
93de5bf
Compare
…ctron-get # Conflicts: # packages/app-builder-lib/src/electron/ElectronFramework.ts # pnpm-lock.yaml # test/snapshots/mac/macPackagerTest.js.snap
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
mmaietta
changed the title
electronDownload to use electron/get official package to support mirrors (BREAKING)electronDownload to use electron/get instead of app-builder
# Conflicts: # vite.config.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from executing
app-builderto using https://github.com/electron/getImplements: #8785
Refactors the code surrounding download/unzip/copy electron before packing begins, so this might also resolve:
#6106
#8687
#8522
#9205