Skip to content

Conversation

mmorel-35
Copy link
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41335 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 2, 2025
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #41335 was opened by mmorel-35.

see: more, trace.

@phlax
Copy link
Member

phlax commented Oct 2, 2025

you will need to update the sha and release date also

there is a tool you can use - eg

bazel run //bazel:api-update com_github_cncf_xds $VERSION_OR_SHA

@mmorel-35
Copy link
Contributor Author

For now I just want to validate cncf/xds#123

@phlax
Copy link
Member

phlax commented Oct 2, 2025

bazel wont load the dep if the sha is incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants