add blockTimestamp to logs

[wighawag]

See corresponding issue : #295

and ethereum-magicians thread : https://ethereum-magicians.org/t/proposal-for-adding-blocktimestamp-to-logs-object-returned-by-eth-getlogs-and-related-requests/11183

[wighawag]

how do we proceed from there to move that forward ?

the ethereum magician thread show enthusiasm about the changes and it should be relatively trivial to implement it across all clients. it is also already implemented in reth

[mattstam]

@lightclient @mkalinin What are the next steps to moving this forward?

[jochem-brouwer]

Hey, I'm not sure, but we have recently started setting up RPC standardization calls and I think this is the place where we want to put/create this process. I think currently there is not a well defined answer on "how to move forward" here 😅. But this is the idea of the call. Today (monday 12 May) is this call, see: ethereum/pm#1529

I will try to join this call and also bring up this PR. I would suggest anyone who provides RPC endpoints to join these calls, because this is the kind of call to bring up changes to the RPC API.

Note: the JSON-RPC API is currently NOT standardized, so this is also part of the call. This repository is kind-of-the-standard, but some clients do not completely support the spec here. We also currently lack tests (there are some, but they definitely do not cover all). The idea for the call is to also collect feedback from RPC providers/users on what is missing.

I know this is kind of a late notice but I would suggest to join it today if possible (15 UTC). For the zoom URL to join, you'd likely have to go to the #json-rpc-api channel of Eth R&D on discord: https://discord.gg/M6wtqNzqjj

CC @wighawag @mattstam

[jochem-brouwer]

I have just asked, the RPC calls are indeed to bring this up 😄 👍 The next call should be in two weeks. If I don't forget, I'll re-link it here 😄

[wighawag]

Thanks @jochem-brouwer!
I was planning to go in the call but in the end was busy with something else. glad to know there will be a call for it in 2 weeks. Hopefuly we can move this forward

[jochem-brouwer]

Next call is scheduled here: ethereum/pm#1544

Hope to see you there 😄 👍 Please note that we are still working on the process itself how to ship these kind of changes, but it would be nice to have an actual proposal there 😄 👍

[miguelmtzinf]

At Aave Labs, we’ve been running into this issue for quite some time—needing to make extra RPC calls just to get the block timestamp for events we’re handling. It’s pretty inefficient, and because of that, we’ve had to explore workarounds like adding extra data to events or including the timestamp directly. We’d really love to see this initiative move forward so node operators include timestamps in the RPC response.

It would make things much more efficient for indexing services and be a real game-changer overall! 🚀

[Neurone]

Hi guys, could you please confirm whether this change has been approved and, if so, merge the PR?

I see that clients (e.g. geth 1.16) and tools (e.g. ethers.js) are starting to support the new blockTimestamp field.

[bmoyroud]

@Neurone - will aim to join the RPC Standards call tomorrow.

Geth and Reth support blockTimestamp in logs now. Discussion for Erigon.

@jflo @poojaranjan - I see a call on the calendar tomorrow but no open issue under the pm repo.

Confirming the call is happening? 😀

[jflo]

Yes, call is happening: ethereum/pm#1605

[lightclient]

Looks like we need some tests to merge this PR!

[fjl]

Tests updated here: #689