Goodwe-Hybrid: make discharge-mode selectable in yaml and ui #24232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Requirement is not entirely clear: #16649 (comment) |
naltatis
changed the title
andig
requested changes
Oct 9, 2025
| "no": "nein", | ||
| "yes": "ja" | ||
| }, | ||
| "dischargemode": { |
There was a problem hiding this comment.
please remove, these are not managed via Weblate
There was a problem hiding this comment.
if i do that it shows.. config.options.dischargemode.1 and config.options.dischargemode.1 same as it does for the Battery mode... not really nice...UX ( just left those 2 alone to have the PR about whats actually done
the construct with having "choice: [2, 8]" in the Template and Strings in the json file makes them more user friendly and translatable... and afaik Weblate is mostly reading the english version of the json file... but the german version is also kept uptodate in the code base...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16649 (comment) and later comments Some users would prefer the old behavior
This pr provides the option to select the Mode via yaml or UI
keeps the current behaviour as a default to not change systems during an update
That should make more users happy
@maatinh & @andiwist should we add "Value 6 "Conserve" as an third viable option?