Skip to content

Goodwe-Hybrid: make discharge-mode selectable in yaml and ui #24232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −1
Draft

Goodwe-Hybrid: make discharge-mode selectable in yaml and ui #24232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions i18n/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@
"no": "nein",
"yes": "ja"
},
"dischargemode": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove, these are not managed via Weblate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i do that it shows.. config.options.dischargemode.1 and config.options.dischargemode.1 same as it does for the Battery mode... not really nice...UX ( just left those 2 alone to have the PR about whats actually done

Bildschirmfoto 2025-10-09 um 13 25 15

the construct with having "choice: [2, 8]" in the Template and Strings in the json file makes them more user friendly and translatable... and afaik Weblate is mostly reading the english version of the json file... but the german version is also kept uptodate in the code base...

"2": "Charge-PV (PV für Batterieladung nutzen)",
"8": "Standby (Batterie im Leerlauf)"
},
"endianness": {
"big": "big-endian",
"little": "little-endian"
Expand Down
4 changes: 4 additions & 0 deletions i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,10 @@
"no": "no",
"yes": "yes"
},
"dischargemode": {
"2": "Charge-PV (use PV to charge battery)",
"8": "Standby (battery idle)"
},
"endianness": {
"big": "big-endian",
"little": "little-endian"
Expand Down
14 changes: 13 additions & 1 deletion templates/definition/meter/goodwe-hybrid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,18 @@ params:
choice: [1, 2]
- name: capacity
advanced: true
- name: dischargemode
default: 2
type: choice
advanced: true
description:
en: Discharge hold mode (2=Charge-PV, 8=Standby)
de: Entladesperre-Modus (2=Charge-PV, 8=Standby)
help:
en: "Mode 2 (Charge-PV): Uses PV power to charge battery, uses grid power for AC loads. Mode 8 (Standby): Battery neither charges nor discharges."
de: "Modus 2 (Charge-PV): Nutzt PV-Strom für Batterieladung, Netzstrom für AC-Lasten. Modus 8 (Standby): Batterie lädt oder entlädt nicht."
choice: [2, 8]
usages: ["battery"]
- name: maxacpower
render: |
type: custom
Expand Down Expand Up @@ -182,7 +194,7 @@ render: |
source: sequence
set:
- source: const
value: 2 # EMSPowerMode 2 "Charge-PV"-Mode. If EMSPowerSet=0 only PV is used to charge. Value 6 "Conserve"-Mode can be alternatively used.
value: {{ .dischargemode }} # EMSPowerMode: 2="Charge-PV" (uses PV to charge, grid for AC loads) or 8="Standby" (battery standby, no charge/discharge)
set:
source: modbus
{{- include "modbus" . | indent 12 }}
Expand Down
Loading