Migrate cpp.type/cpp.template inline annotations to @cpp.Type#486
Open
iahs wants to merge 1 commit intofacebookresearch:v2-betafrom
Open
Migrate cpp.type/cpp.template inline annotations to @cpp.Type#486iahs wants to merge 1 commit intofacebookresearch:v2-betafrom
iahs wants to merge 1 commit intofacebookresearch:v2-betafrom
Conversation
meta-cla
bot
added
the
CLA Signed
Summary:
Migrate inline `(cpp.type = "...")` and `(cpp.template = "...")` annotations on typedefs to `cpp.Type{name = "..."}` and `cpp.Type{template = "..."}` structured annotations in 2 feedsim ranking thrift files.
Also add THRIFT_INCLUDE_DIRECTORIES to the thrift_library() CMake calls so the thrift compiler can find the thrift/annotation/cpp.thrift include file from fbthrift.
Reviewed By: Mizuchi
Differential Revision: D94698697
iahs
force-pushed
the
export-D94698697-to-v2-beta
branch
from
8ba67b2 to
3274853
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
Summary: Pull Request resolved: #486 Migrate inline `(cpp.type = "...")` and `(cpp.template = "...")` annotations on typedefs to `cpp.Type{name = "..."}` and `cpp.Type{template = "..."}` structured annotations in 2 feedsim ranking thrift files. Also add THRIFT_INCLUDE_DIRECTORIES to the thrift_library() CMake calls so the thrift compiler can find the thrift/annotation/cpp.thrift include file from fbthrift. Reviewed By: Mizuchi Differential Revision: D94698697 fbshipit-source-id: 1414cc9d2116b79c6ebce6e3baec90bc4e84a334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Migrate inline
(cpp.type = "...")and(cpp.template = "...")annotations on typedefs tocpp.Type{name = "..."}andcpp.Type{template = "..."}structured annotations in 2 feedsim ranking thrift files.Differential Revision: D94698697