Skip to content

Migrate cpp.type/cpp.template inline annotations to @cpp.Type #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iahs wants to merge 1 commit into from
Closed

Migrate cpp.type/cpp.template inline annotations to @cpp.Type #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/feedsim/third_party/src/workloads/ranking/if/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@ thrift_library(
"${CMAKE_CURRENT_LIST_DIR}" # Directory where thrift file lives
"${CMAKE_CURRENT_LIST_DIR}" # Directory where thrift objects will be built
"ranking/if"
THRIFT_INCLUDE_DIRECTORIES ${FBTHRIFT_INCLUDE_DIR}
)
18 changes: 10 additions & 8 deletions packages/feedsim/third_party/src/workloads/ranking/if/ranking.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
namespace cpp2 ranking

include "thrift/annotation/cpp.thrift"

cpp_include "folly/small_vector.h"
cpp_include "folly/container/F14Map.h"

Expand Down Expand Up @@ -72,14 +74,14 @@ struct Action {
4: i64 actorID;
}

typedef list<i64> (cpp.type = "folly::small_vector<int64_t, 8>") SmallListI64
typedef map<i16, i64> (cpp.template = "folly::F14FastMap") RankingPayloadIntMap
typedef map<i16, string> (
cpp.template = "folly::F14FastMap",
) RankingPayloadStringMap
typedef map<i16, SmallListI64> (
cpp.template = "folly::F14FastMap",
) RankingPayloadVecMap
@cpp.Type{name = "folly::small_vector<int64_t, 8>"}
typedef list<i64> SmallListI64
@cpp.Type{template = "folly::F14FastMap"}
typedef map<i16, i64> RankingPayloadIntMap
@cpp.Type{template = "folly::F14FastMap"}
typedef map<i16, string> RankingPayloadStringMap
@cpp.Type{template = "folly::F14FastMap"}
typedef map<i16, SmallListI64> RankingPayloadVecMap

struct RankingObject {
1: i64 objectID;
Expand Down