-
Notifications
You must be signed in to change notification settings - Fork 2
chore: cleanup CI and minor linting #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs maintenance cleanup of CI configuration and minor linting improvements across the project. The changes focus on consolidating feature flags, improving CI workflows, and standardizing code formatting.
- Introduces a centralized
features_flagvariable to replace repeated--all-featuresflags - Removes obsolete CI triggers and commands while adding new formatting utilities
- Updates various configuration files with cleaner YAML syntax and improved linting rules
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| justfile | Major refactoring to use centralized feature flags, remove unused commands, and add new formatting utilities |
| README.md | Minor spelling correction from "dual licensed" to "dual-licensed" |
| Cargo.toml | Reformats authors array and reorders dependencies, adds cargo clippy linting |
| .pre-commit-config.yaml | Adds pre-commit hooks to forbid and remove tabs |
| .github/workflows/dependabot.yml | Updates action version from specific version to major version |
| .github/workflows/ci.yml | Removes release triggers, adds cargo-binstall tool, and improves job organization |
| .github/dependabot.yml | Converts YAML syntax to more compact inline format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.github/workflows/ci.yml
Outdated
| - if: github.event_name == 'release' | ||
| name: Ensure this crate has not yet been published (on release) | ||
| run: just check-if-published |
Copilot
AI
Aug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line references the check-if-published command which was removed from the justfile, causing the CI job to fail when triggered on release events.
| - if: github.event_name == 'release' | |
| name: Ensure this crate has not yet been published (on release) | |
| run: just check-if-published |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.