Skip to content

Conversation

@nyurik
Copy link
Member

@nyurik nyurik commented Aug 25, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 25, 2025 04:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs maintenance cleanup of CI configuration and minor linting improvements across the project. The changes focus on consolidating feature flags, improving CI workflows, and standardizing code formatting.

  • Introduces a centralized features_flag variable to replace repeated --all-features flags
  • Removes obsolete CI triggers and commands while adding new formatting utilities
  • Updates various configuration files with cleaner YAML syntax and improved linting rules

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
justfile Major refactoring to use centralized feature flags, remove unused commands, and add new formatting utilities
README.md Minor spelling correction from "dual licensed" to "dual-licensed"
Cargo.toml Reformats authors array and reorders dependencies, adds cargo clippy linting
.pre-commit-config.yaml Adds pre-commit hooks to forbid and remove tabs
.github/workflows/dependabot.yml Updates action version from specific version to major version
.github/workflows/ci.yml Removes release triggers, adds cargo-binstall tool, and improves job organization
.github/dependabot.yml Converts YAML syntax to more compact inline format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 25 to 27
- if: github.event_name == 'release'
name: Ensure this crate has not yet been published (on release)
run: just check-if-published
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line references the check-if-published command which was removed from the justfile, causing the CI job to fail when triggered on release events.

Suggested change
- if: github.event_name == 'release'
name: Ensure this crate has not yet been published (on release)
run: just check-if-published

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nyurik nyurik merged commit a229b37 into fast-pack:main Aug 25, 2025
9 checks passed
@nyurik nyurik deleted the lint branch August 25, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants