Supraseal012 #553
Supraseal012 #553
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR tests the "Supraseal012" configuration by updating dependencies and ensuring CI builds work with GCC 12 for CUDA compilation.
Key changes:
- Downgrades FVM dependencies from version 4.7.4 to 4.7.3 and removes the "nv28-dev" feature flag
- Adds
supraseal-c2version 0.1.2 as a dependency (with transitive updates tosppark) - Configures CI workflows to use GCC 12 for all Ubuntu-based build jobs
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/Cargo.toml | Downgrades FVM4 versions to 4.7.3, removes "nv28-dev" feature, and adds supraseal-c2 dependency |
| rust/Cargo.lock | Updates lockfile with new dependency versions including supraseal-c2 0.1.2 and sppark 0.1.14 |
| .github/workflows/ci.yml | Adds GCC 12 installation and environment configuration to check, cgo-bindings, and supraseal jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| CC: gcc-12 | ||
| CXX: g++-12 | ||
| NVCC_PREPEND_FLAGS: "-ccbin /usr/bin/g++-12 -allow-unsupported-compiler" |
There was a problem hiding this comment.
Inconsistent NVCC_PREPEND_FLAGS between jobs. The check job includes -allow-unsupported-compiler flag (line 53), while the supraseal job does not (line 161). For consistency and to avoid potential compilation issues, both jobs should use the same flags. Consider using -ccbin /usr/bin/g++-12 -allow-unsupported-compiler in the supraseal job as well.
1 participant
test the configuration