Skip to content

Supraseal012 #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Supraseal012 #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1800e83
update supraseal
snadrus Nov 10, 2025
59854d5
add dep correctly
snadrus Nov 10, 2025
57ae973
try setting gcc12
snadrus Nov 10, 2025
a6e8eb0
Merge branch 'localss012' into supraseal012
snadrus Nov 10, 2025
dc81115
remove pin
snadrus Nov 11, 2025
9b5b0d5
cleanup nvcc flags
snadrus Nov 11, 2025
61acb51
Merge commit '9b5b0d5' into supraseal012
snadrus Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,17 @@ env:
BELLMAN_CUDA_NVCC_ARGS: --fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75
NEPTUNE_CUDA_NVCC_ARGS: --fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75
DEBIAN_FRONTEND: noninteractive
# Standardize NVCC flags across all jobs
NVCC_PREPEND_FLAGS: "-ccbin /usr/bin/g++-12"

jobs:
check:
name: Check code style and run linters
runs-on: ubuntu-latest
env:
CC: gcc-12
CXX: g++-12
NVCC_PREPEND_FLAGS: "-ccbin /usr/bin/g++-12 -allow-unsupported-compiler"
Comment on lines +52 to +55
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent NVCC_PREPEND_FLAGS between jobs. The check job includes -allow-unsupported-compiler flag (line 53), while the supraseal job does not (line 161). For consistency and to avoid potential compilation issues, both jobs should use the same flags. Consider using -ccbin /usr/bin/g++-12 -allow-unsupported-compiler in the supraseal job as well.

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -57,6 +63,10 @@ jobs:
with:
submodules: recursive
ref: ${{ github.event.inputs.ref }}
- name: Install GCC 12
run: |
sudo apt-get update
sudo apt-get install -y gcc-12 g++-12
- name: Run shellcheck
run: shellcheck ./install-filcrypto
- name: Run cargo fmt
Expand Down Expand Up @@ -100,6 +110,14 @@ jobs:
with:
submodules: recursive
ref: ${{ github.event.inputs.ref }}
- if: runner.os == 'Linux'
name: Install GCC 12 and set environment
run: |
sudo apt-get update
sudo apt-get install -y gcc-12 g++-12
echo "CC=gcc-12" >> $GITHUB_ENV
echo "CXX=g++-12" >> $GITHUB_ENV
echo "NVCC_PREPEND_FLAGS=-ccbin /usr/bin/g++-12 -allow-unsupported-compiler" >> $GITHUB_ENV
- if: runner.os == 'macOS'
run: cd rust && cargo fetch
- name: Build project
Expand Down Expand Up @@ -142,7 +160,6 @@ jobs:
env:
CC: gcc-12
CXX: g++-12
NVCC_PREPEND_FLAGS: "-ccbin /usr/bin/g++-12"
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -153,5 +170,9 @@ jobs:
with:
submodules: recursive
ref: ${{ github.event.inputs.ref }}
- name: Install GCC 12
run: |
sudo apt-get update
sudo apt-get install -y gcc-12 g++-12
- name: Build project with `FFI_USE_CUDA_SUPRASEAL=1`
run: FFI_BUILD_FROM_SOURCE=1 FFI_USE_CUDA_SUPRASEAL=1 make
9 changes: 4 additions & 5 deletions rust/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ rayon = "1.10.0"
anyhow = "1.0.97"
serde_json = "1.0.140"
rust-gpu-tools = { version = "0.7", optional = true, default-features = false }
fvm4 = { package = "fvm", version = "~4.7.4", default-features = false, features = ["verify-signature", "nv28-dev"] }
fvm4_shared = { package = "fvm_shared", version = "~4.7.4" }
fvm4 = { package = "fvm", version = "~4.7.3", default-features = false, features = ["verify-signature"] }
fvm4_shared = { package = "fvm_shared", version = "~4.7.3" }
fvm3 = { package = "fvm", version = "~3.13.0", default-features = false }
fvm3_shared = { package = "fvm_shared", version = "~3.13.0" }
fvm2 = { package = "fvm", version = "~2.11.0", default-features = false }
Expand All @@ -48,6 +48,7 @@ serde = "1.0.219"
safer-ffi = { version = "0.1.13", features = ["proc_macros"] }
filecoin-proofs-api = { version = "19.0", default-features = false }
yastl = "0.1.2"
supraseal-c2 = "0.1.2"

[dev-dependencies]
memmap2 = "0.9"
Expand Down
Loading