Skip to content

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Sep 21, 2025

Related Issues

Proposed Changes

This PR updates Go version used in this repo to 1.24.7 following the repo's go version policy

Additional Info

golangci-lint v1.64 is the last version in the v1 lineage. It has moved on to v2 now. v1.64 does not support Go 1.25 so we'll have to upgrade to v2 before we move on to Go 1.25 ourselves.

Checklist

Before you mark the PR ready for review, please make sure that:

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 21, 2025
@galargh galargh force-pushed the go-1-24-7 branch 2 times, most recently from 86e74ad to 723f50a Compare September 21, 2025 12:58
@galargh galargh requested review from BigLep and rvagg September 21, 2025 13:39
@galargh galargh marked this pull request as ready for review September 21, 2025 13:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation bot moved this from 📌 Triage to ⌨️ In Progress in FilOz Sep 21, 2025
@galargh galargh changed the title Update Go to 1.24.7 chore!: upgrade to Go 1.24 Sep 21, 2025
@github-actions github-actions bot dismissed their stale review September 21, 2025 13:42

PR title now matches the required format.

@BigLep BigLep moved this from ⌨️ In Progress to 🔎 Awaiting Review in FilOz Sep 23, 2025
Updated Go version references and commands in the contributing guide.
@BigLep BigLep requested review from rjan90 and Copilot September 24, 2025 20:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Go version from 1.23.10 to 1.24.7 following the repository's Go version management policy. The upgrade is comprehensive, updating all configuration files, documentation, and build tooling to support the new Go version.

  • Updates Go version specification across all configuration files and documentation
  • Replaces deprecated runtime.GOROOT() calls with dynamic go env GOROOT command execution
  • Updates golangci-lint to v1.64.8 and adds new lint rule exclusions for Go 1.24 compatibility

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Updates Go version directive from 1.23.10 to 1.24.7
GO_VERSION_MIN Updates minimum Go version requirement to 1.24.7
README.md Updates Go version references in badges and installation instructions
Dockerfile Updates base image from golang:1.23.10-bullseye to golang:1.24.7-bookworm
Makefile Updates golangci-lint version to v1.64.8
.golangci.yml Adds exclusions for new Go 1.24 lint warnings
CHANGELOG.md Documents the Go version upgrade
CONTRIBUTING.md Updates Go version management documentation with examples
api/api_test.go Replaces runtime.GOROOT() with dynamic goRoot() function
node/config/dep_test.go Replaces runtime.GOROOT() with dynamic goRoot() function
chain/types/ethtypes/rlp.go Fixes unreachable code by restructuring if-else logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I updated CONTRIBUTING.md a bit more with 9d582b3

But lets wait to merge until you get approval from @rjan90 or @rvagg as they may be aware of any other concerns we need to pay attention to.

Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Will start running the main branch with go updated on my node tomorrow after the network upgrade

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Sep 24, 2025
@rjan90 rjan90 enabled auto-merge (squash) September 25, 2025 12:35
@rjan90 rjan90 merged commit 87a4019 into master Sep 25, 2025
177 of 178 checks passed
@rjan90 rjan90 deleted the go-1-24-7 branch September 25, 2025 12:36
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants