Skip to content

fix(security): Storage limits should be enforced in test/gha-e2e/juicefs/write_job.yaml. #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

fix(security): Storage limits should be enforced in test/gha-e2e/juicefs/write_job.yaml. #5351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/gha-e2e/juicefs/write_job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ spec:
containers:
- name: write-job
image: busybox
resources:
limits:
ephemeral-storage: "5Gi"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with read_job.yaml and to make resource configuration more robust, consider adding a memory limit as well. It's a best practice to set memory and CPU limits to prevent resource exhaustion.

            memory: "512Mi"
            ephemeral-storage: "5Gi"

command: ['sh', '-c', 'mkdir /data/foo && echo helloworld > /data/foo/bar']
volumeMounts:
- name: data-vol
Expand Down
Loading