Skip to content

Conversation

ArvidNy
Copy link
Contributor

@ArvidNy ArvidNy commented Sep 22, 2025

Adds setter for allowing background playback

This PR is a subset of #9212 - it only adds platform interface changes.

Partially resolves #62739.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@ArvidNy ArvidNy requested a review from tarrinneal as a code owner September 22, 2025 15:31
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new method setAllowBackgroundPlayback to the video_player_platform_interface, allowing for dynamic control over background video playback. The changes include adding the method to the VideoPlayerPlatform abstract class, updating the CHANGELOG.md, and incrementing the package version. My feedback focuses on improving the clarity and accuracy of the documentation for this new feature.

ArvidNy and others added 2 commits September 22, 2025 17:39
…G.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…o_player_platform_interface.dart

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2025
@stuartmorgan-g
Copy link
Collaborator

Sorry for the delay in reviewing this sub-PR; I missed the notification among the email updates from #9212

Copy link
Contributor

auto-submit bot commented Oct 10, 2025

autosubmit label was removed for flutter/packages/10054, because - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2025
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2025
@auto-submit auto-submit bot merged commit de7d679 into flutter:main Oct 10, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2025
…background playback This PR is a subset of flutter#9212 - it only adds platform interface changes.  Partially resolves flutter#62739. (flutter/packages#10054)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 13, 2025
flutter/packages@e319c40...d062181

2025-10-10 [email protected] Roll Flutter (stable) from
ac4e799 to 9f455d2 (4 revisions) (flutter/packages#10208)
2025-10-10 [email protected] [video_player_platform_interface] Adds
setter for allowing background playback This PR is a subset of #9212 -
it only adds platform interface changes. Partially resolves #62739.
(flutter/packages#10054)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: video_player

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants