feat(ci): Run type checking on Sentry #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanh
approved these changes
Nov 12, 2025
untitaker
reviewed
Nov 12, 2025
| run: | | ||
| cd sentry | ||
| python -m tools.fast_editable --path . | ||
| sentry init |
Member
There was a problem hiding this comment.
should not be needed just for typechecking
Member
Author
There was a problem hiding this comment.
without this step, the sentry package is missing in uv for some reason and there would be a ModuleNotFoundError for the sentry module when running type check.
untitaker
approved these changes
Nov 12, 2025
Member
Author
|
making sure CI passes with latest main changes before merging |
Member
Author
|
Sentry typecheck failing example/test: https://github.com/getsentry/sentry-kafka-schemas/actions/runs/19307754659/job/55219632954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs STREAM-547