Skip to content

feat(ci): Run type checking on Sentry #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 12, 2025
Merged

feat(ci): Run type checking on Sentry #456

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b7daebe
feat(ci): Run type checking on Sentry
lvthanh03 Nov 10, 2025
22e47c1
style(lint): Auto commit lint changes
getsantry[bot] Nov 10, 2025
7dbe10a
Use action-setup-venv
lvthanh03 Nov 10, 2025
f9f9ed6
Use correct env
lvthanh03 Nov 10, 2025
402e727
No venv typo
lvthanh03 Nov 10, 2025
4c2769d
Run mypy in uv
lvthanh03 Nov 10, 2025
eb626d0
Run mypy in venv
lvthanh03 Nov 10, 2025
22a0e99
Install sentry via fast_editable
lvthanh03 Nov 10, 2025
b3d9d28
Merge branch 'main' into tony/sentry-mypy
lvthanh03 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,51 @@
- name: Run mypy
run: |
make type-checking
sentry-typing:
name: "Sentry type checking"
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: astral-sh/setup-uv@884ad927a57e558e7a70b92f2bccf9198a4be546 # v6
name: Setup uv
with:
version: "0.8.2"
enable-cache: false
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
name: Checkout sentry-kafka-schemas
with:
path: sentry-kafka-schemas
- name: Build sentry-kafka-schemas
run: |
cd sentry-kafka-schemas
python -m pip install --upgrade pip
make install
make build
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
name: Checkout sentry
with:
repository: getsentry/sentry
path: sentry
- uses: getsentry/action-setup-venv@3a832a9604b3e1a4202ae559248f26867b467cc7 # v2.1.1
with:
python-version: 3.13
cache-dependency-path: sentry/uv.lock
install-cmd: cd sentry && uv sync --frozen --active
- name: setup sentry
run: |
cd sentry
python -m tools.fast_editable --path .
sentry init
Copy link
Member

@untitaker untitaker Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be needed just for typechecking

Copy link
Member Author

@lvthanh03 lvthanh03 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this step, the sentry package is missing in uv for some reason and there would be a ModuleNotFoundError for the sentry module when running type check.

- name: Install sentry-kafka-schemas
run: |
cd sentry
uv pip install ../sentry-kafka-schemas/dist/*.whl
- name: Run mypy for sentry
run: |
cd sentry
PYTHONWARNINGS=error::RuntimeWarning mypy

tests:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
name: "Run tests"
runs-on: ubuntu-latest
strategy:
Expand Down
Loading