Skip to content

Conversation

DS204ever
Copy link

Changed drag preview from control to window which fixes viewport clipping issues.

Changelog:

  • Changed drag preview type from Control to Window.
  • Added new method in Window which changes window's position to mouse's in order to track mouse position.

Relations:

Known issues:

  • When the global project setting embedded subwindows is enabled it is not possible to drag and drop data from the main window into an external window.
embedded_windows.mp4
external_windows.mp4

@DS204ever DS204ever requested a review from a team as a code owner September 22, 2025 19:11
@DS204ever DS204ever requested a review from a team as a code owner September 23, 2025 21:26
@DS204ever
Copy link
Author

Unit tests were failing in test case [TextEdit] text drag.
I think that the mouse event wasn't updating the window drag preview correctly or enough times for it to change location, I increased the movement amount before releasing the drag in an attempt to fix this and it seems to have worked.
I have also replicated the test manually in the editor and it behaves as expected, which leads me to believe this is only an issue for the unit test and does not replicate the real scenario.

@DS204ever DS204ever requested a review from a team as a code owner September 23, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag previews clipped by Popup that created them
3 participants