Add Android instrumented tests to the app module
#110829
Open
+933
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match the default configuration Both the `app` and `lib` modules had custom source sets configuration originating from the early days of the project. This updates the configuration to match the default Android Studio configuration which will simplify the addition of unit tests and instrumented tests to the project. Note that for backcompat reasons, some folders (such as the `res` folder in the `app` module) are left as is.
|
@syntaxerror247 To complete the integration, we'll need to set up the CI to automatically run the integrated tests. Can you look into what it'd take to make this happen. This blogpost seems like a good reference to start with: https://medium.com/@peterkagure/running-instrumented-tests-on-github-actions-with-firebase-test-lab-ac17bb36ae9c |
This builds on the work from @dsnopek in https://github.com/dsnopek/javaclasswrapper-test, by importing the set of JavaClassWrapper tests from that repo within the Godot core repo in order to bootstrap and standardize how we write and run Android instrumented tests. The approach used here should serve as a base to build upon to expand the set of instrumented tests used to validate the project's stability. Co-authored-by: David Snopek <[email protected]>
m4gr3d
force-pushed
the
javaclasswrapper_regression_tests
branch
from
c3148e9 to
3397456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial set of instrumented tests to the Godot
appmodule which should help us improve stability of the engine and detect regressions.To do so, the PR is split into two commits (note: I recommend reviewing each commit by themselves):
The first commit updates the project layout for both the
appandlibmodules in order to align with the default Android Studio project layout. Doing so allow us to more easily set up, use and contribute to instrumented tests for the project. While the commit looks large, it mostly consists of moving files around, and doesn't contain much logical changes except where updates to project paths were needed.The second commit sets up the instrumented tests folder layout and build config for the
appmodule. A newinstrumentedproduct flavor is created which defines a custom Godot project and custom test plugins that are launched when running instrumented tests. The Godot project and test plugins are imported from @dsnopek https://github.com/dsnopek/javaclasswrapper-test repo, and theJavaClassWrappertests it contains make up the initial set of instrumented tests.