Fix cannot edit property material for new Instance PackedScene #112334
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
When we create a new instance
PackedScene, then create a new Material for this embedded node. The properties of the new material will all read-only, until we save and reopen the scene.The reason is
EditorResourcePickertry to get scene_path from node to locate the resource of material. But embedded node returns its own scene_path, which is different from root scene_path.godot/editor/inspector/editor_resource_picker.cpp
Lines 643 to 646 in 0fdbf05
The inspector determines we cannot edit embedded scene's property, then mark them as read-only. After saving and reopening scene, the relevant scene path will be corrected, so we can edit these properties.
godot/editor/inspector/editor_inspector.cpp
Line 3886 in 0fdbf05
Solution
We can use the root scene path of editing scene, when current node path is different.
material.webm