Scene Dock: Simplify Filter Nodes related UI #112343
Open
+18
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The menu options don't mention shorthands ( |
timothyqiu
force-pushed
the
filter-nodes
branch
from
2526c42 to
1d4a807
Compare
timothyqiu
changed the title
|
Updated. The shorthand is now mentioned in the menu item's tooltip. See OP. |
|
Placeholder part is actually covered by #107942 |
KoBeWi
reviewed
Nov 6, 2025
| void _filter_gui_input(const Ref<InputEvent> &p_event); | ||
| void _filter_option_selected(int option); | ||
| void _append_filter_options_to(PopupMenu *p_menu, bool p_include_separator = true); | ||
| void _append_filter_options_to(PopupMenu *p_menu, bool p_include_separator); |
There was a problem hiding this comment.
tbh the separator argument can be removed and just check whether the menu already has items.
Comment on lines
4022
to
4024
| void SceneTreeDock::_update_tree_menu() { | ||
| PopupMenu *tree_menu = button_tree_menu->get_popup(); | ||
| tree_menu->clear(); |
There was a problem hiding this comment.
I just realized that this menu doesn't need to be re-created every time. Only needs to update the checkboxes.
You could change it, but idk if it's within scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current placeholder is too long for regular usage.
It was introduced to enhance the discoverability of the filtering syntax. But nowadays, the filter options are available in the related menus. It's no longer necessary to use this placeholder I think.
The syntax is already mentioned in the LineEdit's tooltip. It is now also added to the tooltip of the related menu items:
Options in the context menu:
Options in the three-dots menu:
There is also a filters popup menu for middle mouse button click in the LineEdit. This PR makes it created on demand.