Prevent emitting signals when previewing resource #112547
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meorge
approved these changes
Nov 8, 2025
Contributor
Meorge
left a comment
Meorge
left a comment
There was a problem hiding this comment.
Tested on both cases brought up in #112503 (tile set for TileMapLayer and albedo texture for StandardMaterial3D), and they maintain their selection now, along with Sprite2D's texture.
I don't have any particular ideas for specific cases to try where suppressing signals for this period could cause problems. Perhaps if there are editor plugins that add additional visualizations to the scene based on the loaded resource, they wouldn't update until the user has confirmed the selection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112503
The intention is to block property list changed signal, but not sure if there aren't any important signals needed in some nodes.