feat(makernote): add Fujifilm MakerNote parser#33
Merged
Conversation
Implements Fujifilm MakerNote parsing with: - FUJIFILM header detection (8-byte signature + 4-byte IFD offset) - Relative offset handling (offsets relative to MakerNote start) - 80+ tag name mappings (SerialNumber, Quality, FocusMode, etc.) - Comprehensive unit tests Also updates: - Register Fujifilm handler in TIFF parser with priority ordering - Test framework: ExactTagCount -1 skips tag count validation - CR2 integration test: Canon directory presence-only check Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
tech-lead-02 Review: APPROVED ✅Fujifilm implementation matches my research findings exactly. Verified:✅ Header: 'FUJIFILM' (8 bytes) + 4-byte IFD offset Key Implementation Details Correct:
CI passing (Build/Lint/Test/Coverage). Merging now! |
This was referenced Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/parser/tiff/makernote/fujifilm/fujifilm.go- Main handler implementationinternal/parser/tiff/makernote/fujifilm/lookup.go- Tag name mappingsinternal/parser/tiff/makernote/fujifilm/fujifilm_test.go- Comprehensive unit testsinternal/parser/tiff/tiff.go- Register Fujifilm handlerinternal/testing/- ExactTagCount -1 for presence-only directory checksapi_integration_test.go- Updated CR2 test for Canon MakerNoteKey implementation details
OffsetRelativeToMakerNote(offsets are relative to MakerNote start, not TIFF/EXIF base)Test plan
🤖 Generated with Claude Code