Skip to content

feat(makernote): add Fujifilm MakerNote parser #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpuneet merged 1 commit into from
Feb 7, 2026
Merged

feat(makernote): add Fujifilm MakerNote parser #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions api_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ func TestIntegration_CR2(t *testing.T) {
},
{
Name: "ExifIFD",
ExactTagCount: 27,
ExactTagCount: 26, // MakerNote is now parsed into Canon directory
Tags: []imxtest.TagExpectation{
// All tags with exact values where possible, binary data checked for presence only
{Name: "ExposureTime", Value: "1/100"},
Expand All @@ -282,7 +282,7 @@ func TestIntegration_CR2(t *testing.T) {
{Name: "MeteringMode", Value: "Multi-segment"},
{Name: "Flash", Value: "Off, Did not fire"},
{Name: "FocalLength", Value: "85/1"},
{Name: "MakerNote", Type: "[]byte"}, // Binary data - check presence only
// MakerNote is now parsed into Canon directory
{Name: "UserComment", Type: "[]byte"}, // Binary data - check presence only
{Name: "FlashpixVersion", Value: []byte{48, 49, 48, 48}}, // "0100" in hex
{Name: "ColorSpace", Value: "sRGB"},
Expand All @@ -305,6 +305,10 @@ func TestIntegration_CR2(t *testing.T) {
{Name: "JPEGInterchangeFormatLength", Value: uint32(13120)},
},
},
{
Name: "Canon",
ExactTagCount: -1, // Presence check only - Canon MakerNote content varies by camera model
},
})
if result.Failed() {
for _, err := range result.Errors {
Expand Down
Loading
Loading